(compat) Fix incorrect usages of storage service at Runtime and Loader layer#25722
Merged
agarwal-navin merged 1 commit intomicrosoft:mainfrom Oct 21, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes incorrect usages of storage service types at the Runtime and Loader layers following the introduction of IContainerStorageService and IRuntimeStorageService. The changes ensure the correct storage service interfaces are used in mock implementations and type annotations.
Key Changes
- Updated mock storage service implementations to use
IContainerStorageServiceinstead ofIRuntimeStorageService - Corrected import statements to reference the appropriate storage service types
- Removed a test that verified
getSnapshotTreeinaccessibility from data store context, which is now obsolete
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/test/test-end-to-end-tests/src/test/deRehydrateContainerTests.spec.ts | Removed obsolete test case that checked storage access restrictions in detached containers |
| packages/runtime/container-runtime/src/test/containerRuntime.spec.ts | Updated mock storage service types from IRuntimeStorageService to IContainerStorageService |
| packages/loader/container-loader/src/container.ts | Corrected parameter type in initializeProtocolStateFromSnapshot from IDocumentStorageService to IContainerStorageService |
github-actions
bot
added
area: loader
jason-ha
approved these changes
Oct 21, 2025
Contributor
jason-ha
left a comment
jason-ha
left a comment
There was a problem hiding this comment.
Maybe strike the last sentence of the PR description.
Also, even if we were to keep this, we would have to cast data store context's storage any or one of the storage service interfaces from upper layer which again doesn't test anything useful.
I think it just adds confusion. It is enough to say it isn't useful.
anthony-murphy-agent
pushed a commit
to anthony-murphy-agent/FluidFramework
that referenced
this pull request
Jan 14, 2026
…r layer (microsoft#25722) There are a couple of incorrect usages of the storage service at the Runtime and Loader layer after `IContainerStorageService` and `IRuntimeStorageService` were added by microsoft#25057. This PR fixes them. Also, removed a test that was ensuring `getSnapshotTree` cannot be accessed from data store context. With microsoft#25057, `getSnapshotTree` is not accesible from data store context's storage anymore so this test is not needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are a couple of incorrect usages of the storage service at the Runtime and Loader layer after
IContainerStorageServiceandIRuntimeStorageServicewere added by #25057. This PR fixes them.Also, removed a test that was ensuring
getSnapshotTreecannot be accessed from data store context. With #25057,getSnapshotTreeis not accesible from data store context's storage anymore so this test is not needed.